bitpay / bitcore

A full stack for bitcoin and blockchain-based applications
https://bitcore.io/
MIT License
4.85k stars 2.09k forks source link

[BCN] Fix gas estimation #3583

Closed kajoseph closed 1 year ago

kajoseph commented 1 year ago

Some errors seen:

error: { code: -32000, message: 'insufficient funds for transfer' } error: { code: -32000, message: 'err: max fee per gas less than block base fee: address <redacted address>, maxFeePerGas: 38300000000 baseFee: 39828234137 (supplied gas 215685)' } error: { code: -32000, message: 'gas required exceeds allowance (63)' } error: { code: 3, message: 'execution reverted: Must have enough tokens to pay', data: '<redacted>' }

This fixes the first two. I'm not sure there's much we can do to mask the last two errors but pass it through BWS better. That might be a subsequent PR.

This also updates some pipeline pieces.

KiniaSss commented 1 year ago

Niektóre widoczne błędy:

error: { code: -32000, message: 'insufficient funds for transfer' } error: { code: -32000, message: 'err: max fee per gas less than block base fee: address <redacted address>, maxFeePerGas: 38300000000 baseFee: 39828234137 (supplied gas 215685)' } error: { code: -32000, message: 'gas required exceeds allowance (63)' } error: { code: 3, message: 'execution reverted: Must have enough tokens to pay', data: '<redacted>' }

To naprawia pierwsze dwa. Nie jestem pewien, czy możemy wiele zrobić, aby zamaskować dwa ostatnie błędy, ale lepiej przekazać je przez BWS. To może być kolejny PR.