bitpay / bitcore

A full stack for bitcoin and blockchain-based applications
https://bitcore.io/
MIT License
4.85k stars 2.09k forks source link

[Client] Add --addressType to wallet creation; Squish all the bugs! :bug: #3638

Closed kajoseph closed 11 months ago

kajoseph commented 1 year ago

Currently, bitcore-client wallets are pubkeyhash wallets only. This adds the ability to create wallets using other address types.

Note, taproot addresses are not fully implemented in bitcore-lib yet and don't work (hence the bypass in the tests)

Also, this fixes several bugs:

kajoseph commented 1 year ago

@escottalexander phew! pipeline is passing again. NPM really didn't like me manually adding those dev dependencies.

escottalexander commented 1 year ago

@kajoseph Still need to address this: https://github.com/bitpay/bitcore/pull/3638#discussion_r1346338177 I think it got lost when you pushed changes to fix the pipeline.