bitpay / bitcore

A full stack for bitcoin and blockchain-based applications
https://bitcore.io/
MIT License
4.8k stars 2.07k forks source link

[BCC] Fix XRP issues with bitcore-client #3647

Closed kajoseph closed 8 months ago

kajoseph commented 8 months ago

This removes the semvar from the ripple-lib dep in CWC. ripple-lib v1.10.1 was being installed in other environments which caused the following error when signing an XRP tx TypeError: Cannot read properties of undefined (reading 'encodeForSigning')

Additionally, I've cleaned up the check for needing change addresses and effectively excluded XRP wallets from creating change addresses as well.