search

bitpay / cordova-plugin-qrscanner

A fast, energy efficient, highly-configurable QR code scanner for Cordova apps and the browser.
MIT License
568 stars 772 forks source link

android:required only works for <uses-feature> not <uses-permission> #111

Closed kongyim closed 6 years ago

kongyim commented 6 years ago

Please check plugin.xml line 23

the android:required field is useless, please remove it. Manifest merger will fail with multiple errors

from <uses-permission android:name="android.permission.CAMERA" android:required="false" />

to <uses-permission android:name="android.permission.CAMERA" />

Otherwise, if other plugin having android.permission.CAMERA permission will have merge conflict

aramando commented 6 years ago

Yes please remove this as it seems to be causing this plugin to not play nicely with others that also use the camera. I just had to remove and re-add my whole Android platform to stop duplicate entries being created in my AndroidManifest.xml and failing the build.

bitjson commented 6 years ago

Is this still an issue?

(Going to close for now, but please feel free to send a PR if something still needs to change.)

kamiljackiewicz commented 5 years ago

This is still an issue. Other plugins which have android.permission.CAMERA permission have merge conflicts.

Please update plugin.json: from

    <config-file target="AndroidManifest.xml" parent="/*">
      <uses-permission android:name="android.permission.CAMERA" android:required="false" />
      <uses-feature android:name="android.hardware.camera" android:required="false" />
      <uses-feature android:name="android.hardware.camera.front" android:required="false" />
    </config-file>

to

    <config-file target="AndroidManifest.xml" parent="/*">
      <uses-permission android:name="android.permission.CAMERA" />
      <uses-feature android:name="android.hardware.camera" />
      <uses-feature android:name="android.hardware.camera.front" />
    </config-file>
CjoyHome commented 5 years ago

This is still an issue

CjoyHome commented 5 years ago

image ![Uploading image.png…]()

jhgeluk commented 4 years ago

Still experiencing this issue!

zuzkadirova commented 4 years ago

Please check plugin.xml line 23

the android:required field is useless, please remove it. Manifest merger will fail with multiple errors

from <uses-permission android:name="android.permission.CAMERA" android:required="false" />

to <uses-permission android:name="android.permission.CAMERA" />

Otherwise, if other plugin having android.permission.CAMERA permission will have merge conflict

Wjejj3