search

bitpay / insight

A bitcoin blockchain explorer and API
https://insight.bitpay.com/
MIT License
1.19k stars 1.11k forks source link

Redirect /tx -> /#/tx #915

Closed micahriggan closed 6 years ago

micahriggan commented 6 years ago

The goal of this is to redirect frontend requests, like /tx to /#/tx

This may need exclusion of /api, or perhaps we want an explicit whitelist.

martindale commented 6 years ago

Is this tested?

martindale commented 6 years ago

@micahriggan after applying locally, I'm still getting 404s on all old links; for example, /address/3DZse1LBPbihrJCSsGEiYb5uWNRnhMawEW returns the following:

Cannot GET /address/3DZse1LBPbihrJCSsGEiYb5uWNRnhMawEW

Is this intended to be a permanent (301) or a temporary (302) redirect? I'm planning on upgrading a production instance of Insight, can't have old links breaking.

matiu commented 6 years ago

@martindale I think this is only for /tx, /address should be fixed also. It should be a permanent redirect.

martindale commented 6 years ago

This still does not work locally.