bitpay / magento2-plugin

Magento2.x payment plugin for Bitpay.com
MIT License
13 stars 24 forks source link

Fix bug related to saveConfig scope type (issue 19) #20

Closed linden2015 closed 6 years ago

linden2015 commented 7 years ago

Config's Resouremodel's saveconfig function was called with an incorrect scope type leading to an application crash after saving the value to the core config database.

/Model/MagentoStorage.php and /Helper/Data.php now have the scope config set to SCOPE_TYPE_DEFAULT when they call saveConfig.

The goal of the previous code is unclear to me as the storemanager was called to request the current store, which is independent of the chosen scope in the admin for setting configuration values.