bitpay / prestashop-plugin

BitPay payment plugin for PrestaShop
MIT License
23 stars 32 forks source link

PrestaShop v1.6.0.9: Some Formating Issues #17

Closed Master0ne closed 9 years ago

Master0ne commented 10 years ago

Using the default template, the BitPay box is not properly formated on the OPC (quick-order):

opc

The problem seems to be that it does not properly get included encapsulated in a row. This is how it should look like:

row

And this is how it looks for the bitpay module:

bitpay_no_row

As you can see, the two divs are missing, and just the paragraph getting inserted, causing the bitpay box stretch uncontrolled horizontally.

I have already tried to find the issue in the code by comparing the files in the bitpay module folder with the ones in the bankwire module folder, but I have no idea what I'm looking for.

Another problem: Although the bitpay module is installed and enabled properly, it does not show up on the Modules>>Payment page as active payment module:

modules_payment_page

Master0ne commented 10 years ago

FYI I am running latest PrestaShop v1.6.0.9 and the server is running Apache. The server was configured with PHP 5.5.17 till now, but I have just switched back to PHP 5.4.33 (because of the APC option, which is not available any more starting with PHP 5.5, and PrestaShop currently does not seem to make use of the PHP 5.5 OPcache caching system), and the two issues are still there, so this has nothing to do with the PHP version.

Master0ne commented 10 years ago

With the help of Christian Jensen (developer of the PrestaShop Piwik Module) I was able to solve that problem by exchanging the content of the file /modules/bitpay/views/templates/hook/payment.tpl with the following code:

<div class="row">
    <div class="col-xs-12 col-md-6">
        <p class="payment_module bitpay">
            <a href="{$this_path}payment.php" title="{l s='Pay with BitPay' mod='bitpay'}">
                <img src="{$this_path}bitcoin.png" width="86" height="49" alt="{l s='Pay with BitPay' mod='bitpay'}" />
                {l s='Pay with Bitcoin' mod='bitpay'}
             </a>
        </p>
    </div>
</div>
<style>
        p.payment_module.bitpay a 
        {ldelim}
                padding-left:17px;
        {rdelim}
</style>

I guess the proper procedure would be a fork + patch + pull request, but I'm not a developer and I've never done that before.

JoshuaEstes commented 10 years ago

Yeah, if you fork and make some commits, do a pull request and then we will check it out and pull it in when we have the time.

Thanks!

GenZai commented 10 years ago

Hello, Same problem as Master0ne the module installed properly but it doesn't show in my module list. I'm on Prestashop 1.6.0.6

Master0ne commented 10 years ago

@GenZai, that does not seem to be the same problem, the module is showing up fine under Modules, but not under Payment. See these two pictures:

bitpay_bo_modules bitpay_bo_payment

Master0ne commented 10 years ago

Forgot to mention, there is a also something BitPay related showing up at the top when viewing orders independently if an order has been paid by Bitcoin or not. See this picture (which was an order not paid with Bitcoin):

bitpay_order

Not sure if that is intended or now, but I guess rather not?

Master0ne commented 10 years ago

Thanks for the pull, @philosodad, but without the added style the Bitpay logo is off to the right as shown above. It is handled similarly in the PayPal module to get it in line with the other payment modules.

GenZai commented 10 years ago

@Master0ne Sorry I thought it was the same problem. Actually, when I upload from the backoffice I receive the message "The module was downloaded successfully." but it doesn't even show in the ftp in modules/bitpay. So the solution is to upload the bitpay folder directly on the ftp, then it shows in the backoffice. And the install went fine.

Master0ne commented 10 years ago

@GenZai, that is because there hasn't been a release yet and you have to rename the folder in the zip when downloading from master.

ionux commented 9 years ago

This issue is fixed in the latest official Release. It has been re-packaged correctly and will be going forward, as well.