search

bitpay / ruby-client

Powerful, flexible, lightweight SDK for the BitPay Bitcoin Payment Gateway API.
MIT License
79 stars 64 forks source link

Bump rack to unblock rails 4.2 #45

Closed saizai closed 9 years ago

saizai commented 9 years ago 
bitpay-client (>= 2.2.0) ruby depends on
  rack (~> 1.5.2) ruby

rails (>= 4.2.1) ruby depends on
  railties (= 4.2.1) ruby depends on
    actionpack (= 4.2.1) ruby depends on
      rack (~> 1.6) ruby
saizai commented 9 years ago

(Also, bump gem)

saizai commented 9 years ago

Travis CI fail is unrelated, due to features/step_definitions/keygen_steps.rb:4 (see travis log)

philosodad commented 9 years ago

We have a separate rails gem that works on rails 4.2.1, and the current version of bitpay-sdk is 2.4.4. This is essentially deprecated code... is there a reason you want to update this version?

For clarity, this repository references the bitpay-sdk gem, not bitpay-client.

saizai commented 9 years ago

@philosodad I wasn't aware of https://github.com/bitpay/bitpay-rails. I suggest that you at least edit the README on this repo to indicate that it's deprecated and point to the new one.

philosodad commented 9 years ago

This repo is not deprecated, the version of the gem (2.2.0) is. The current gem is 2.4.4, and is housed in this repo.

The bitpay-rails gem is a separate gem that depends on this gem, the bitpay-sdk gem. The bitpay-client gem is this gem plus a cli, it also isn't deprecated but does need to be updated. The repo for that gem is https://github.com/bitpay/ruby-cli.

bitpay-key-utils ( generating keys, signing, identification )
     |
bitpay-sdk ( general purpose REST connector and convenience methods, imports key-utils )  
-------------------
|                 |
|                  bitpay-client (bitpay-sdk + a command line tool)
bitpay-rails         
( 1 model, imports bitpay-sdk )

I agree, this might be somewhat confusing and will add a note to the README explaining which gems are available from bitpay and perhaps when you might you them. Hope the rails gem works out for you, let us know if you have any problems.