search

bitpay / ruby-client

Powerful, flexible, lightweight SDK for the BitPay Bitcoin Payment Gateway API.
MIT License
79 stars 64 forks source link

Allow new rack v2 for Rails 5 apps #51

Closed javierjulio closed 8 years ago

javierjulio commented 8 years ago

Rails 5 now requires Rack 2 which in turn requires Ruby 2.2.2 and up. This update still allows Rack 1 on older Ruby versions that aren't compatible with Rack 2 but then support upgrading.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 91.096% when pulling 1da5ba688c4f20a67adbd999fdd513fafb35a846 on javierjulio:patch-1 into 0ec4bb11056df5fd581834a25aa56c9df1166e25 on bitpay:master.

javierjulio commented 8 years ago

After discussing with one of my coworkers he asked why rack is even used? I searched for it and while its defined as a dependency it doesn't seem to be used in code anywhere. Is it used for something important? Could the dependency possibly be removed?

philosodad commented 8 years ago

This library was tied to the rails library at one point, possibly this dependency is just left over.

On Mon, Aug 1, 2016 at 4:07 PM, Javier Julio notifications@github.com wrote:

After discussing with one of my coworkers he asked why rack is even used? I searched for it and while its defined as a dependency it doesn't seem to be used in code anywhere. Is it used for something important? Could the dependency possibly be removed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitpay/ruby-client/pull/51#issuecomment-236691996, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIQybMM36aK5gvN57_IjhgojYvvH4uVks5qblISgaJpZM4JZw_g .

J. Paul Daigle

javierjulio commented 8 years ago

This is resolved by my other PR #53 that's already been merged.