search

bitpay / virtuemart-plugin

BitPay payment plugin for VirtueMart
MIT License
9 stars 21 forks source link

bitcoin address is absolutly wrong. #24

Closed mfarooqi closed 6 years ago

mfarooqi commented 6 years ago

I'm using Virtuemart 3 Payment plugin of bitcoin. When I use checkout with IOS/Andoid apps and scan the QRcode that works fine. but when I follow "copy address" method.. I'm getting this URL.. which is I think wrong. bitcoin:?r=https://bitpay.com/i/Tppy5qDjKGegM4zfXSjqqW

While your own documentation says.. it should be.. something like..

according to https://en.bitcoin.it/wiki/Address.

  1. Common P2PKH which begin with the number 1, eg: 1BvBMSEYstWetqTFn5Au4m4GFg7xJaNVN2.
  2. Newer P2SH type starting with the number 3, eg: 3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy

What do you think? what's wrong in it..

pieterpoorthuis commented 6 years ago

Since Dec 22nd 2017 BitPay only allows deposits by 'payment protocol' compatible bitcoin wallets. The reason we did this is to eliminate payment exceptions (over/under/late/double payments). You can read more about the success of eliminating payment exceptions here: https://blog.bitpay.com/payment-protocol-results/

The best information to pay an invoice can be found here: https://support.bitpay.com/hc/en-us/articles/115005559826 This is the same link that is displayed on the invoice.

mfarooqi commented 6 years ago

Thank you for the details.. Appreciated.