search

bitpay / wallet

Bitpay Wallet (formerly Copay) is a secure Bitcoin and other crypto currencies wallet platform for both desktop and mobile devices.
http://bitpay.com/wallet
MIT License
3.78k stars 1.74k forks source link

importing a BIP 39 wallet is too complicated #5721

Open NicSil opened 7 years ago

NicSil commented 7 years ago

Looking for a wallet software I can propose to bitcoin newbies, I think importing a BIP39 seed is TOO COMPLICATED (add wallet/create new wallet/advanced option/wallet-key = recovery phrase). I don't understand why the simple AddWallet/importwallet does not suit the case.

dabura667 commented 7 years ago

wallet software I can propose to bitcoin newbies

So a wallet that is easy to create a first wallet

I think importing a BIP39 seed is TOO COMPLICATED (add wallet/create new wallet/advanced option/wallet-key = recovery phrase)

But this is not what you do for a first wallet.......?

Which one is your issue? Pick one.

I agree that recovery from phrase, as well as importing phrase from other wallet is a VERY complicated process for users. (If it's from another wallet, Create New Wallet >> Advanced Options, but if it is a recovery for old Copay wallet it's Import Wallet >> Advanced Options)

In fact, the act of taking a phrase generated by another app and trying to bring it into Copay, most people would call that "importing" to Copay, but that is the type you need to do from the "Create New Wallet" screen... kind of confusing.

NicSil commented 7 years ago

So more info! We give BTC to our customers/friends (150 wallets for DigitalAirways.com 's 2017 greeting card). We give BIP39 pre created and funded wallets and a FAQ to educate them. Wallet usually contain 0.03 BTC.

Thus, you understand that i'm looking for a software that easily imports a BIP39 seed!

Giszmo commented 7 years ago

@dabura667

In fact, the act of taking a phrase generated by another app and trying to bring it into Copay, most people would call that "importing" to Copay, but that is the type you need to do from the "Create New Wallet" screen... kind of confusing.

Yes, please, you already have a hint there to go to "new wallet" instead. How about automating this? Typing in 12 words is a pain and having to type them twice is twice the pain and absurd if the app already has all the data I want to give it.

Also in this context, allow me to bump #3757

matiu commented 7 years ago

you can use a QR code to export tjmge seed. Then in Bitpay App just scan tje QR and the wallet will be imported.

On Mar 7, 2017 12:19 PM, "Leo Wandersleb" notifications@github.com wrote:

@dabura667 https://github.com/dabura667

In fact, the act of taking a phrase generated by another app and trying to bring it into Copay, most people would call that "importing" to Copay, but that is the type you need to do from the "Create New Wallet" screen... kind of confusing.

Yes, please, you already have a hint there to go to "new wallet" instead. How about automating this? Typing in 12 words is a pain and having to type them twice is twice the pain and absurd if the app already has all the data I want to give it.

Also in this context, allow me to bump #3757 https://github.com/bitpay/copay/issues/3757

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitpay/copay/issues/5721#issuecomment-284751357, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHK3rynGpYqpLJonfzae3_36UJ-Mkks5rjXWPgaJpZM4MTc1I .

matiu commented 7 years ago

JFYI, the relevant code for creating the QR for Copay is here:

https://github.com/bitpay/copay/blob/master/src/js/services/walletService.js#L1013

On Tue, Mar 7, 2017 at 2:01 PM, Matias Alejo Garcia ematiu@gmail.com wrote:

you can use a QR code to export tjmge seed. Then in Bitpay App just scan tje QR and the wallet will be imported.

On Mar 7, 2017 12:19 PM, "Leo Wandersleb" notifications@github.com wrote:

@dabura667 https://github.com/dabura667

In fact, the act of taking a phrase generated by another app and trying to bring it into Copay, most people would call that "importing" to Copay, but that is the type you need to do from the "Create New Wallet" screen... kind of confusing.

Yes, please, you already have a hint there to go to "new wallet" instead. How about automating this? Typing in 12 words is a pain and having to type them twice is twice the pain and absurd if the app already has all the data I want to give it.

Also in this context, allow me to bump #3757 https://github.com/bitpay/copay/issues/3757

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitpay/copay/issues/5721#issuecomment-284751357, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHK3rynGpYqpLJonfzae3_36UJ-Mkks5rjXWPgaJpZM4MTc1I .

-- Matías Alejo Garcia @ematiu Roads? Where we're going, we don't need roads!

dabura667 commented 7 years ago

@matiu I just tried creating my own QR with a brand new BIP39 phrase I generated on my own...

  1. The only place to scan the QR for BIP39 phrase is in the "Import Wallet" screen. scanning from any other screen gives an error.
  2. When I scan a QR with all the encoded info (1|phrase...|m/44'/0'/0'/|false) it says "this wallet does not exist on this BWS instance" as an error. (which is exactly the problem the user is facing)

The QR option would be a nice way to make importing QR very easy for new users.

However,

  1. They would need to generate every wallet using Copay and the Bitpay BWS...
  2. They still need to tell their users "ok, you MUST use the Import screen, because if you put the phrase into the "Create Wallet" screen, it will give you an error."
  3. If they use 3rd party software to make the BIP39 phrases, they have the same problem with the QR, as trying to use the phrase in "Import Wallet" will give an error.

Suggestion:

  1. IF you create a wallet using 12 word phrase, AND Copay notices that the wallet already exists on the server.......... it should import that wallet.
  2. IF you enter a 12 word phrase into Import Wallet, and it doesn't exist on the server... pop up to the user "This wallet was never seen before by this BWS. Please create a new wallet." with two buttons "create personal wallet" "create shared wallet" and tapping them will automatically send you to the Create wallet screen of the one they chose, with Advanced options open and their BIP39 phrase already entered along with any password they might have entered

The confusion comes from which tab to enter the BIP39 phrase on (most users do not understand how BWS works with Copay) and are confused when a red block of text says things that makes no sense to them ("Why doesn't it just work?" they think) So the app should not only show red text, but guide them to their destination, and remove as much hassle (re-typing phrases etc.) as possible.

NicSil commented 7 years ago

Another discussion, but: where can I find a documentation on what is stored (seed? private keys? public?) on the server and why is this necessary

most users do not understand how BWS works with Copay) and are confused when a red block of text says things that makes no sense to them ("Why doesn't it just work?" they think)

So true...

NicSil commented 7 years ago

To date, your users were Level 1: bitcoin specialist. Now you reach level 2 (i'm part of) advanced users but not specialist. Digital Airways's greeting card with pre founded wallets were sent to level 3: clever and smart people but completely newbies. Be prepared to target them (before level 4: my mother).

kristoffernolgren commented 6 years ago

@NicSil This your giveaway is nice, but it's not a very good best practice, since you now can access their entire wallet, even if they add more funds. You might not intend to do something bad, but it's still a system risk to promote bad practices. I would suggest giving them a private key and have them sweep it instead.