search

bitpay / wallet

Bitpay Wallet (formerly Copay) is a secure Bitcoin and other crypto currencies wallet platform for both desktop and mobile devices.
http://bitpay.com/wallet
MIT License
3.8k stars 1.74k forks source link

Recovery Tool for Trezor shared wallets #6645

Closed AdvancedStyle closed 6 years ago

AdvancedStyle commented 7 years ago

I'm trying to understand how you would recover funds in a multi-sig shared Copay wallet, with all trezor signers, if copay.io disappears?

It appears the Copay Recovery Tool (https://github.com/bitpay/copay-recovery) does not support trezor?

So if copay services go away, your funds are stuck?

JDonadio commented 7 years ago

It appears the Copay Recovery Tool (https://github.com/bitpay/copay-recovery) does not support trezor?

Yes. Unfortunately is not supported for now.

So if copay services go away, your funds are stuck?

https://github.com/bitpay/copay/wiki/COPAY---FAQ#if-copayio-disappears-is-there-a-procedure-to-recover-my-funds

AdvancedStyle commented 7 years ago

So if copay services go away, your funds are stuck?

https://github.com/bitpay/copay/wiki/COPAY---FAQ#if-copayio-disappears-is-there-a-procedure-to-recover-my-funds

This link is to the tool that you said won't work?

JDonadio commented 7 years ago

Yes you're right, in your case you'll not be able to recover the funds if that happends.

blueknight02 commented 7 years ago

This is a HUGE problem for the many people that use your Copay service along with hardware wallets. They expect to have the upmost security, and now your saying that recovery is impossible. This issue should be stated in bold when referring people to use hardware wallets on Copay. It's a major security risk and quite unacceptable that this is the case.

JDonadio commented 7 years ago

JFYI: We are planning to support BCH within the app which actually support HW, so hopefully both of you guys will be able to claim your BCH soon. Follow https://github.com/bitpay/copay/issues/6557

blueknight02 commented 7 years ago

That's very good news. Any idea on when that might be ready?

On Aug 31, 2017 2:16 PM, "Javier Donadío" notifications@github.com wrote:

JFYI: We are planning to support BCH within the app which actually support HW, so hopefully both of you guys will be able to claim your BCH soon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitpay/copay/issues/6645#issuecomment-326379581, or mute the thread https://github.com/notifications/unsubscribe-auth/ARvQuUS0MfmIeiYfU_d1usLMIVEFFGkzks5sdviXgaJpZM4PDuiS .

JDonadio commented 7 years ago

A good approach > next week.

blueknight02 commented 7 years ago

It's been almost a month now, any idea on when this feature will be ready?

Sabbe commented 7 years ago

Indeed. An update on the HW supported BCH recovery would be GREAT. This is really really needed.

matiu commented 6 years ago

We are working on this this week. Please see https://github.com/trezor/connect/issues/83

blueknight02 commented 6 years ago

Please also support Ledger devices, which enabled BCH recovery months ago

On Oct 23, 2017 8:25 AM, "Matias Alejo Garcia" notifications@github.com wrote:

We are working on this this week. Please see trezor/connect#83 https://github.com/trezor/connect/issues/83

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitpay/copay/issues/6645#issuecomment-338641921, or mute the thread https://github.com/notifications/unsubscribe-auth/ARvQuSMgkc9Bd9pzjX82N2UWjHT_UT-Aks5svIWggaJpZM4PDuiS .

johnvamo commented 6 years ago

Hi,

Keep waiting for the solution of HW copayers....Thanks...

matiu commented 6 years ago

Just to be clear, are you all talking about BCH, right?

I want to clariry that It is possible to recover a trezor waller from the trezor backup works in Copay (btc)

On Oct 24, 2017 00:40, "johnvamo" notifications@github.com wrote:

Hi,

Keep waiting for the solution of HW copayers....Thanks...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bitpay/copay/issues/6645#issuecomment-338863649, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHAnS8XKKpnTU-joM-7erpAIx-HKyks5svVwdgaJpZM4PDuiS .

johnvamo commented 6 years ago

Hi,

Yes, I am talking about claiming Bitcoin cash from a copay shared wallet integrated with Trezor. How is it possible to claim them? The recovery tool did not worked out. Thanks for your support.

matiu commented 6 years ago

@johnvamo got it. Thanks.

We are working to integrate BCH to Copay Trezor integration now, we hope to finish that in the next few days.

johnvamo commented 6 years ago

Thanks for your support.

gabrielbazan7 commented 6 years ago

I'm waiting for Trezor team response to continue the work with this integration. https://github.com/trezor/connect/issues/85

Sabbe commented 6 years ago

Any comment on the Ledger based wallet BCH recovery? Been waiting for ages.

gabrielbazan7 commented 6 years ago

@Sabbe I'm also working on the Ledger integration. But the documentation is not clear. https://github.com/LedgerHQ/ledger-wallet-api/issues/13.

Sabbe commented 6 years ago

@gabrielbazan7 Do you need help in communicating with Ledger? I know them fairly well and could persuade to improve documentation asap. Tell me if that is needed.

gabrielbazan7 commented 6 years ago

Yes please! Thanks

blueknight02 commented 6 years ago

Any updates on this on Ledger integration? It's been months now, and with another hard fork looming I'm afraid it will never be resolved. I'll be changing wallet services and removing my high recommendations of Copay if so. @JDonadio @gabrielbazan7 @matiu

johnvamo commented 6 years ago

Hi,

"We are working to integrate BCH to Copay Trezor integration now, we hope to finish that in the next few days."

What about copay Trezor shared wallet to claim BCH...no tool possible yet ?

Thanks for your support.

Sabbe commented 6 years ago

I'm trying to nudge the Ledger team now to help with this. Hopefully they will soon.

Sabbe commented 6 years ago

@gabrielbazan7 I got in touch with Ledger CTO, he promised to take a look at that soon.

johnvamo commented 6 years ago

@matiu Please give us any news about trezor integration please...

chriswilmer commented 6 years ago

@matiu : This is still unresolved right? It's a bit unsettling! The reason I loved Copay so much was precisely because of Copay+Trezor integration... and now I'm anxious about my Bitcoin Cash!

gabrielbazan7 commented 6 years ago

We are working on it. We will let you know.

JasonGreyman commented 6 years ago

Waiting on 1.0 BCH for this problem as well, as I sent it to a SegWit-formatted address for my Trezor (starting with "3" in the BCH address) at:

https://blockchair.com/bitcoin-cash/transaction/243856554#o=0

ledgeruser commented 6 years ago

I'm using MultiSig shared Copay wallet with Ledger being used as signer 2. My BCH balance is displayed on my phone (signer 1) but will not populate copay chrome app on computer as the second signer is the Ledger. I can initiate the transfer of BCH from my phone but cannot sign with signer 2. Frustrating that my BCH is essentially held hostage in Copay!

Sabbe commented 6 years ago

Hello @gabrielbazan7 can you update on the current status of the Ledger integration? Has Ledger improved things at their end? Their CTO promised to take a look at this.

johnvamo commented 6 years ago

I just got this message from Trezor:

"BitPay has recently announced that it will discontinue its Copay bitcoin wallet Chrome app, due to Google’s decision about Chrome apps’ end-of-life in 2018. As a consequence, multisig wallets with TREZOR as a co-signer will no longer be available after this date.

If you stored your bitcoins on a multisig wallet with the help of Copay bitcoin wallet, we strongly recommend moving your funds to your TREZOR"

and:

Hi John,I'm sorry but there is really nothing we can do about this, the ball is on Copay's side of the court right now. Please, contact them.I hope this was helpful. Hi John,I'm sorry but there is really nothing we can do about this, the ball is on Copay's side of the court right now. Please, contact them.I hope this was helpful.

Hi John,I'm sorry but there is really nothing we can do about this, the ball is on Copay's side of the court right now. Please, contact them.I hope this was helpful.

We need to claim our bitcoin cash before it is over copay support...please any good news...because the ones I am showing here are not.

Thank you for your support till the end....

JOHN   |    

matiu commented 6 years ago

@ledgeruser @Sabbe no, there is no news from Ledger.

Please see the complete End-of-life statement at https://blog.bitpay.com/copay-chrome-end/

In order to claim your multisig BCH from trezor/ledger you can: 0- you will need to import for hw seed into Copay SOFTWARE wallet, therefore you should hard reset your hw wallet afterwards to have a private key that never was on a computer/phone.

1- go you import, and enter the 24 words, select "from hardware wallet"

2- duplicate the wallet to BCH

3- sign an outoging TX

4- sign from the other software copayer.

alypseak commented 6 years ago

Thank you @matiu

johnvamo commented 6 years ago

Hello @matiu,

Thanks for your quick response.

I am not understanding your instructions.

When you mean software wallet...is the copay wallet where my multisignature funds are...right?

Then if I go to "import wallet"...I have separate options for the words seed and hardware wallet...so where to start from? Duplicate the wallet to BCH...you mean select BCH? Where do I sign for an outgoing TX?

Thanks for the clarifications you can give us.

JOHN

matiu commented 6 years ago

@johnvamo

When you mean software wallet...is the copay wallet where my multisignature funds are...right?

I mean you will need to sign the transaction with a software wallet (ie Copay on a desktop) and not use your Trezor/ledger. To do so, you will need to import the seed from your Trezor/Ledger in Copay.

Then if I go to "import wallet"...I have separate options for the words seed and hardware wallet...so where to start from?

You need to enter the 24 backup words from Trezor / Leder.

Duplicate the wallet to BCH...you mean select BCH? no, import it using BTC, one it is imported, go to settings and duplicate it to BCH.

Where do I sign for an outgoing TX?

In the software wallet you just imported. You dont need the Trezor/Ledger since the key was imported.

bitpay_-_secure_bitcoin_wallet_and_recovery_tool_for_trezor_shared_wallets_ _issue__6645_ _bitpay_copay
johnvamo commented 6 years ago

Hi @matiu,

I imported successfully my copay trezor wallet...but when duplicating...the multisignature wallet ( Fondo TV) is not elegible to be duplicated....why? the one that is elegible is a normal copay wallet...

I have done the process in just one of the 2-2 copayers...

walletimportedtrezor

What is next then?

Thanks for your support.

JOHN

johnvamo commented 6 years ago

@matiu , I understand the recovery tool does not work for copay integrated with Hardwallets...

Look at the response from Trezor:

screen shot 2017-11-22 at 11 46 58 am

I really need to go through this claim process...Thanks again for your support.

chriswilmer commented 6 years ago

@matiu : A step-by-step explanation of how to move BCH from a 2-of-2 Copay/Trezor wallet (even if it means importing the recovery seed) would be really really really helpful!

johnvamo commented 6 years ago

@matiu,

Researching...I found it:

screen shot 2017-11-22 at 10 08 53 pm

My copay multisignature wallet is BIP48, thats why is nos eligible for duplicate for BCH...(only BIP44)

How to resolve it???

Thanks again...

Anyone has gone successfully claiming BCH as mentioned above?

corebindallas commented 6 years ago

Hi @matiu and other copay/bitpay staff

I am also in the same boat as everyone else which is really unfortunate. We understand this software is provided without warranty but we would still expect to have a mechanism for this process.

As was mentioned here because of the derivation path we can not sweep our multi-sig BIP48 trezor wallets.

Is there anything we can do to get this resolved? it would be nice to also do this for the BTG fork at some point.

Even if the process is more complicated or requires us leveraging another application such as electrum we would be happy to give that a try with a little guidance.

Thank you for your help and Copay has been an amazing piece of software and it's clear that this is something that we can all work together towards solving if we can all be made aware of the obstacles. I may be able to contribute resources if I was fully aware of the constraints.

chriswilmer commented 6 years ago

Could we use this? (would have to edit source code to allow 44 --> 48 for path derivation

https://iancoleman.io/bip39/

johnvamo commented 6 years ago

Any one here from Copay support??? Thank you...

corebindallas commented 6 years ago

Hi Please help resolve the issue with not being able to sweep the BIP48 derivation path multi sig trezor wallet or give us some guidance. This is totally lacking in professionalism that we arent even being given a response. If it is impossible please tell us why and tell us to go fly a kite at least.

JDonadio commented 6 years ago

Please see this comment: https://github.com/bitpay/copay/issues/6645#issuecomment-346151743

matiu commented 6 years ago

@johnvamo I was able to reproduce the error you are mentioning.

It is fixed on Chrome App version v3.9.9. Please note you need Chrome App v3.9.9 in order to be able to duplicate BIP48 wallets, it won't work on other platforms.

v3.9.9 was already submitted to the Chrome store. It should be available soon for all users.

So, the procedure to access BCH from a multisig software wallet is:

Please see the complete End-of-life statement at https://blog.bitpay.com/copay-chrome-end/

In order to claim your multisig BCH from trezor/ledger you can:

0- you will need to import for hw seed into Copay SOFTWARE wallet, therefore you should hard reset your hw wallet afterwards to have a private key that never was on a computer/phone.

1- Using Copay Chrome App Version v3.9.9; go you import, and enter the 24 words, select "from hardware wallet"

2- duplicate the wallet to BCH

3- sign an outgoing TX

4- sign from the other software copayer.

johnvamo commented 6 years ago

Hello @matiu,

I am glad to hear from you. I will try it...and tell you what happened. Thanks.

johnvamo commented 6 years ago

Hello @matiu,

I claimed successfully the bitcoin cash...

But, here some tips to get it correctly...

1.When I imported the wallet with the 24 words seed...I change the derivation path from m/44'/0'/0' to m/48'/0'/0' otherwise the wallet is not shown...

  1. Then I could duplicate the wallet...when sending from the copay wallet important to put before the address "bitcoincash:" then the address.

Reading: https://www.yours.org/content/increasing-merchant-adoption-of-bitcoin-cash-e3167e2fa326/

I hope anyone with the same situation can solve it at last...

johnvamo commented 6 years ago

@matiu,

I forgot to Thank you so much for your support. Happy Christmas!

corebindallas commented 6 years ago

@matiu Thank you very much I can confirm the same as @johnvamo It's important for the user to duplicate the derivation path as it is currently in their hardware + copay wallet. In my case I used a second account on the trezor so my path was m/48'/0'/1' also I wasn't able to add the wallet until I deleted the original wallet which uses the trezor seed the application complained.

Thank you all so much we appreciate all the hard work the product is amazing and I really hope the native applications will implement hardware seeds but with a little more transparency on how to recover them in the event copay vanishes (we hope not) or that one of these forks happens again (we also hope not) it's always nice to be able to access funds if it is normally possible.