bitprj / bit-frontend

Frontend for the LMS (Learning Management System)
https://bitproject.org
13 stars 6 forks source link

Create [FeaturedActivity] component #16

Closed poroia closed 4 years ago

poroia commented 4 years ago

Create a component that will be used as a "featured" content for a particular page. This will need to accept dynamic props like title, description, authors, and will likely eventually need to be connected to our API, but the API part is not part of this issue.

image The component is under the Explore, World, Activity, and Module pages under Student View on the Figma.

For now, place this component under src/components/shared/high

This component can be directly created in the World component. This component can be accessed through src/components/World/World.js. As shown in App.js, this component/view can be accessed by typing in the url: /world/:id where :id is equal to any number

JersinFong commented 4 years ago

I'm going to working on this!

JersinFong commented 4 years ago

image I almost finished this component, the only issue is that icon size inside the IconLine component is fixed(1em), if I used it to render Icon, the icon size does not fit in the text size. Should I change the Icon size or text size?

lazyplatypus commented 4 years ago

all the emojis need to be svgs to maintain continuity across all devices.

lazyplatypus commented 4 years ago

Um i think before we merge this we have to make small design changes, but just create a pull req to new-ui whenever you are ready and we can set up a meeting to merge it :)

JersinFong commented 4 years ago

Sure, I will do this tomorrow!