Generate no links by setting ticket number to 0

keimlink commented 11 years ago

This is a new approach to solve the problem with changelog entries having no issue. It is an updated version of @hynek's pull request #1. I know you were not happy about the hack. So why do I create an updated pull request?

AFAIK it's not possible to have roles in docutils that have no or empty arguments. So it won't be possible to have a role with an optional ticket number, like you proposed in TODO.
Optional options would be possible with directives. But as you wrote in TODO there is the downside of getting very huge entries compared to what we have now. And I agree that the current list of items is as simple as it can and should be.
Line items without an issue role have problems: You can't set the major keyword and therefore they go always into bugfix releases - even if you wanted something different!

If this pull request looks like a good solution for you, you can reject my other pull request #3 because this solution totally fits my needs.

bitprophet commented 10 years ago

Yea, I think here I do have to bow to pragmatism and use this shorthand, because yup - using directives would be cleaner, but significantly more verbose due to ReST semantics (e.g. all dat whitespace in between everything) and the tersity of this approach is one of its major benefits.

I tested out your change and it seems to work fine (barring other, known issues such as #9) and it is cleaner than #1's implementation :) Thanks!

bitprophet commented 10 years ago

Something struck me this morning - we don't have to use numbers at all for this, could use something even more obviously non-issue-numeric like a dash (-). E.g.:

* :bug:`-` Blah blah

Will experiment with this briefly to see how it looks, but I like the idea of making these non-issue-related "issues" even more distinct. cc @keimlink @hynek

keimlink commented 10 years ago

Sounds like a good idea!

bitprophet commented 10 years ago

Ended up just letting either suffice :) so now a dash OR a zero may be used, up to the user. Could probably just expand further to be "any non numeric value, or a zero" but meh, effort.

bitprophet / releases

Generate no links by setting ticket number to 0 #10