Closed sigmavirus24 closed 7 years ago
@sigmavirus24 Same, also broke on my projects when pyup PR'd the update.
Mildly worried the "default to None" fix may cause other brokenness (if we assumed the attr existed before & were using it for reasons...) but given it passes the test suite...probably fine? Thanks for the report & the PR.
bitprophet closed this in #67 3 minutes ago
What is this (new?) witchcraft, GitHub?! Only thing I can see that might have caused that (as you can tell, I am used to having to trigger closure via changelog commits...) is that @sigmavirus24's PR says Closes #66
in its body text...
I'm sneaky. š
So am I right about the text hint working in PR description fields as in commit messages...or do you have Github superpowers? š®
So in a commit message or PR description it'll work and has since before I became a maintainer of Requests (years ago). It's not new, but it's kind of sneaky.
If you:
tox -e docs
you'll reproduce it. The logs from sphinx are here:I'll take a look into fixing this later, but I don't have the time right this second. :)