search

bitquest / bitquest

A Minecraft server with Blockchain economy
http://bitquest.org
Other
150 stars 68 forks source link

Need the 200 bit Minimum added back to code. #113

Closed Burntuno closed 7 years ago

Burntuno commented 7 years ago

There needs to be a way to stop and warn players that wallet minimum is 200 bits.

Lord-Felidae commented 7 years ago

That makes sense, maybe check the transaction amount and cancel transactions less than 200b

Burntuno commented 7 years ago

Main reason is Miner Fees. Miner Fees cost 60 to 150 bits for 1 transaction, no matter the amount. If players start sending 20 bit transactions, costing server more than 60 bits, it would drain Fees Wallet. Since loots are 200 bits and claims are 200 bits, it just makes sense to keep minimum transfers at 200 bits also. In another Issue, it is suggested we make a player paid 200 bit fee on off site withdraws, to help prevent those who win, withdraw, win, withdraw. This happens and has a 2X affect on Miner Fees used.

Lord-Felidae commented 7 years ago

This is related somewhat to your other issue #103. And I agree with both of these issues, because I think miner transaction fees should be payed for by players.

Lord-Felidae commented 7 years ago

Can anyone tell me how to PR? I've never done it before, and I have a solution to this. Edit: IF I can do it correctly, (@explodi will probably have to review it.)

Lord-Felidae commented 7 years ago

@Burntuno I made a PR, (and a few mistakes, as seen above) to fix this.

Lord-Felidae commented 7 years ago

@explodi, please review and merge my PR

explodi commented 7 years ago

Hi, the transactions in future versions will use a different API, so in order to merge this PR i need the new API working.

You can see how this is being made on the last commits (56d0a81828c834f49999617c636f8079f95ed400, 1d3686e2d5c8d5a785f443669abe7ad1beb80471)

To clarify, this PR will be, merged but in a commit using a the new API.

Lord-Felidae commented 7 years ago

Ok, but additionally, would I have to change something because of the conversion to Edit: @explodi is Bitquest offline because of the Xapo thing? Edit 2: I think you can bring BQ online, except disable the ability to transfer. @Burntuno if he does so, we're all gonna need to spread word through BQ, everywhere.

explodi commented 7 years ago

We'll be using Xapo for cash outs. All other transactions will happen on an internal ledger. I am making a beta test for this new development. You can check the progress of the beta builds here:

http://beta.bitquest.co:8080/job/bitquest/

Will attempt merge this PR now.

explodi commented 7 years ago

Just realized this is not a PR but an issue. Nevermind

explodi commented 7 years ago

In the new off-chain builds, a 200 bit minimum is not needed (cause there's no fees!) but there will be a minimum in cashouts (/transaction)

I think it's gonna be 1000 or 10000. If it's a e-mail payout via xapo it will be free, but on-chain blockcypher transactions will cost the user a feedetermined by the Bitcoin market. This is subject to change as the beta builds are tested.

Lord-Felidae commented 7 years ago

Wonderful! So Xapo API has free transfers?

explodi commented 7 years ago

I'm not sure how it works fee wise, I just implemented the API found on http://developers.xapo.com. I chose xapo because its a very respectable company in security of Bitcoins, but we had implemented their API version 1. This is the implementation for version 2.

Lord-Felidae commented 7 years ago

I feel like we should make a deadline and/or checklist for BQ 3 😀