search

bitrich-info / xchange-stream

XChange-stream is a Java library providing a simple and consistent streaming API for interacting with Bitcoin and other crypto currency exchanges via WebSocket protocol. It is build on top of of XChange library providing new interfaces for streaming API. User can subscribe for live updates via reactive streams of RxJava library.
Apache License 2.0
413 stars 222 forks source link

xchange-cexio NotYetImplementedForExchangeException #247

Closed firepol closed 4 years ago

firepol commented 5 years ago

Hi, I was trying the cex.io websocket (OrderBooks) but I got NotYetImplementedForExchangeException

I see in fact in the CexioStreamingMarketDataService class that every method throws that exception.

I was wondering if the creator of that draft is planning to finalize it?

Thanks for letting me know & best regards

fynnfluegge commented 5 years ago

I'm going to add Cexio Support to my app, so will to implement it soon :)

firepol commented 5 years ago

Nice, make sure, if you subscribe to many exchanges at the same time in parallel (as I did in my little app https://github.com/firepol/crypto-websockets ) to test cex.io and binance at the same time (in another app I did, in python, I get some false positive errors from binance that I have to ignore... happens only when subscribing cex.io and binance websockets in parallel, with other exchanges no issue)

fynnfluegge commented 5 years ago

What do you mean by false positive error in that context?

firepol commented 5 years ago

What do you mean by false positive error in that context?

I mean I was getting an error and I was handling all errors in the same way: unsubscribe from the channel. Like that I basically lost all binance connections. After debugging it for a while I discovered that ignoring the error was the way to make it work, that's why "false positive": an error that I can ignore is a false alarm, it's no error. The funny thing was that I had no errors with binance together with many other exchanges: bitfinex, bitstamp, coinbase pro etc. the errors happened only in binance, when adding cexio to the mix.

So this maybe is a strange bug in the tooling I was using, which you can check out here, in case you are interested: https://github.com/firepol/ccxt-websockets-db-updater which is based on a fork of CCXT work in progress. But it works like a charm.

I created an issue for this weird problem: https://github.com/firepol/ccxt-websockets-db-updater/issues/4

Again, maybe in xchage-stream you won't have any trouble, sharing just in case...

badgerwithagun commented 4 years ago

Closing as stale. Please re-open if this is still an issue.