badgerwithagun
commented
5 years ago @galic1987:
- Binance and Coinbase Pro are supposed to work this way - you are supposed to specify your subscriptions on connection. In fact, for cross-compatibility, you should do this for all exchanges. Some don't need it, some do.
- Bitmex support is quite broken. We have a lot of PRs submitted but not enough people willing to review them, so I wouldn't recommend using Bitmex support at the moment.
- CEX.IO support is being added right now
- The others: have you tried the latest version?
It is very hard to create meaningful unit tests since most of the code relies on exchange connectivity and none of the exchanges provide stubs. Generally, the best developers can do is to make sure that their code maps known examples of websocket data.
There are "example" classes for manual testing, which are usually used by developers when working on changes, but running them on Travis would make the build fail half the time. I've been there with my own project - having to bypass tests to try and get a fix out during a 6-hour Binance outage is no fun.
galic1987
I tested the 4.3.11 trades API with BTC_USD(T) and I can confirm the following working:
Rest: Binance: Exception in thread "main" java.lang.IllegalArgumentException: Subscriptions must be made at connection time Can we merge this? https://github.com/bitrich-info/xchange-stream/issues/140
BitMex: INFO: Disconnected from the Exchange (after 10 seconds)
Poloniex : Just hangs in there
CexIO: Feature not yet implemented for exchange.
GDax: The ProductSubscription must be defined!
Bitflyer: INFO: Disconnected from the Exchange (after 10 seconds)
Wex: we can remove this one
Questions: 1) Did anyone tried contacting the exchanges to see if they would like provide developers for the project? It is in their interest. 2) Can we create some simple unit tests?