search

bitrich-info / xchange-stream

XChange-stream is a Java library providing a simple and consistent streaming API for interacting with Bitcoin and other crypto currency exchanges via WebSocket protocol. It is build on top of of XChange library providing new interfaces for streaming API. User can subscribe for live updates via reactive streams of RxJava library.
Apache License 2.0
414 stars 219 forks source link

XChange 4.4.1 has been released #510

Closed pchertalev closed 4 years ago

pchertalev commented 4 years ago

XChange 4.4.1 has been released, develop version is 4.4.2-SNAPSHOT for now. Guys, are we going to release XChange-stream 4.4.1 as well? @badgerwithagun @dozd

mdvx commented 4 years ago

any chance we can move up to XChange 4.4.2-SNAPSHOT? Is there a chatroom for us to discuss these issues? @badgerwithagun @dozd

pchertalev commented 4 years ago

I'm developing Kraken Futures API at the moment and I need to add some XChange changes as well - but versions are different xchange-stream (4.4.1-SNAPSHOT) vs xchange (4.4.2-SNAPSHOT)

pchertalev commented 4 years ago

@badgerwithagun @dozd

badgerwithagun commented 4 years ago

There's nothing I can do. All PR merging is currently blocked because of a travis issue and I don't have the access necessary to bypass it. Waiting on @dozd.

dozd commented 4 years ago

Uf missed this one. I will solve that tomorrow.

dozd commented 4 years ago

@badgerwithagun I increased your access so you can bypass whatever you need. I'll solve that travis tomorrow though

TSavo commented 4 years ago

Any update on this? I sent an email to @badgerwithagun regarding taking over the maintainer role, I would love to take a more active role in moving this rapidly forward.

dozd commented 4 years ago

@badgerwithagun are we good? I see builds on travis.

dozd commented 4 years ago

Or you wanna me release develop under 4.4.1 and prepare for the next iteration?

badgerwithagun commented 4 years ago

Hey @dozd, yeah I've got on top of the PRs now!

A 4.4.1 release would be good, then sure, we can bump master to 4.4.2-SNAPSHOT.

badgerwithagun commented 4 years ago

Hey @TSavo, sorry I've not replied directly to your message. I refer you to this thread: https://github.com/knowm/XChange/issues/3220 in which it was agreed to merge xchange-stream into XChange itself.

To make that happen we really need help getting the project tidied up and prepared for a repository merge, and a plan for how to make the merge work cleanly. We'd need some good quality PRs and a bit of history with the project before adding a new maintainer (especially after the merge with XChange) so If you could fire some PRs through to help with this, that would be greatly appreciated.

TSavo commented 4 years ago

You got it! :)

badgerwithagun commented 4 years ago

@dozd: xchange 4.4.2-SNAPSHOT has breaking changes and breaks xchange-stream. I am working on a PR to fix these and bump the dependency, which I'll put up shortly. If you could create the 4.4.1 release first, that'd be great.

badgerwithagun commented 4 years ago

@dozd ok, that PR (#529) is ready to go when the release is done.

dozd commented 4 years ago

Releasing right now!

badgerwithagun commented 4 years ago

Thanks @dozd. Updated to 4.4.2-SNAPSHOT now. Closing this.