search

bitrich-info / xchange-stream

XChange-stream is a Java library providing a simple and consistent streaming API for interacting with Bitcoin and other crypto currency exchanges via WebSocket protocol. It is build on top of of XChange library providing new interfaces for streaming API. User can subscribe for live updates via reactive streams of RxJava library.
Apache License 2.0
414 stars 219 forks source link

Making all online tests @Ignore to allow build to work with no Internet connection. Fixes #357 #530

Closed TSavo closed 4 years ago

TSavo commented 4 years ago

Sometimes tests that require an active connection to exchange cause the build to fail because of a problem on the exchange side. This PR changes all the online tests to @Ignore to avoid any possible build errors due to remote services being unavailable. Fixes #357

To find these I literally unplugged my internet connection and ran all the tests, only @Ignore -ing the ones which failed.

badgerwithagun commented 4 years ago

Or... Rather than using a profile, we could shift the matching tests to running in failsafe instead of surefire, and allow the build to pass if failsafe reports errors.

TSavo commented 4 years ago

Or... Rather than using a profile, we could shift the matching tests to running in failsafe instead of surefire, and allow the build to pass if failsafe reports errors.

I will look into that! :)

TSavo commented 4 years ago

Closing this PR to do a failsafe integration instead.