search

bitrich-info / xchange-stream

XChange-stream is a Java library providing a simple and consistent streaming API for interacting with Bitcoin and other crypto currency exchanges via WebSocket protocol. It is build on top of of XChange library providing new interfaces for streaming API. User can subscribe for live updates via reactive streams of RxJava library.
Apache License 2.0
414 stars 219 forks source link

[develop] Maven format has been added to pom.xml, but not run. Running the maven build formats everything. #531

Closed TSavo closed 4 years ago

TSavo commented 4 years ago

The impending change to add the coveo format plugin has been submitted to develop, but the format has not been run and the formatted files have not been committed to maven.

Running mvn clean test causes maven to format all the files, resulting in a huge change set of freshly formatted files. Right now, if you want to run the maven build on develop, you'll need to comment out the plugin in the pom.xml.

Simply comment out the following lines: `

       <plugin>
            <groupId>com.coveo</groupId>

            <artifactId>fmt-maven-plugin</artifactId>

            <version>2.9</version>

            <configuration>

                <filesNamePattern>.*\.java</filesNamePattern>

                <skip>false</skip>

            </configuration>

            <executions>

                <execution>

                    <goals>

                        <goal>format</goal>

                    </goals>

                </execution>

            </executions>

        </plugin>`

And run the build as normal. Then when you go to check in, be sure to not include pom.xml in your commit. We can close this bug when the formatted files have been committed to development.

TSavo commented 4 years ago

The project is formatted! :)