search

bitrig / bitrig-ports

Bitrig Ports collection repository.
25 stars 17 forks source link

add x11/st scrollback feature #54

Closed strake closed 9 years ago

natano commented 9 years ago

Is this the same patch as available at http://st.suckless.org/patches/st-scrollback.diff ? It would be preferable to not duplicate the patch locally, but pull it from there during build when a specific flavor is activated. See mail/mutt/Makefile for reference how the mechanism works (PATCHFILES, FLAVORS, MASTER_SITES1).

strake commented 9 years ago

On 04/01/2015, Martin Natano notifications@github.com wrote:

Is this the same patch as available at http://st.suckless.org/patches/st-scrollback.diff ? It would be preferable to not duplicate the patch locally, but pull it from there during build when a specific flavor is activated.

No, that patch seems against an earlier version, and anyhow introduces a bogus pointer fault which mine doesn't.

jcvernaleo commented 9 years ago

@natano and @strake Where did you two leave this PR? Should I go and test it or was it waiting on something?

strake commented 9 years ago

For my part it's ready to go.

jcvernaleo commented 9 years ago

Had to rebase it with the latest master so this didn't automatically close, but it looks good and works for me so it is in. Thanks!