search

bitrinjani / castable

Castable library sanitizes dirty external data by casting all properties at runtime to the types specified at compile time.
27 stars 3 forks source link

Make `convert` a utility method rather than private class member #4

Open jloveridge opened 6 years ago

jloveridge commented 6 years ago

While I don't particularly like prefixing with __ as a method of hiding private methods I think it best to avoid using any kind of name that might reasonably be expected on an arbitrary object extending Castable.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f29f7bf0fae1238b306a638604675a3025b3d533 on gradecam:feature/allow-convert-property into 109f38a9ce4b65710ea42d3eb7e0760b36aa4e85 on bitrinjani:master.

jloveridge commented 6 years ago

Updated to avoid needing to have any private convert/__convert method which I think is a better option anyway.