search

bitrinjani / r2

R2 Bitcoin Arbitrager is an automatic arbitrage trading system powered by Node.js + TypeScript.
MIT License
787 stars 259 forks source link

Support of other trading pairs #95

Open haisongdong-harrison opened 6 years ago

haisongdong-harrison commented 6 years ago

Sorry that this issue is in English. Thanks a lot for your great work!

It seems that the altcoin(e.g. ETH, BCH) markets usually have a larger price discrepancy than the BTC one. And they are highly correlated to, but less exploited than the BTC market. This r2 framework looks pretty well-rounded and I was wondering if it is possible to support other trading pairs other than just BTC/JPY.

Could there be an argument to select the pair (or several pairs) user wants to trade when starting the program? (I haven't read all the API documentation but I guess it's only about changing the symbol?)

Thank you in advance!

PeterGrainfield commented 6 years ago

There's no such option now, BTC/JPY only.

R2 supports three exchanges operated in Japan. All of them provides BTC/JPY. Other pairs are not common among exchanges.

haisongdong-harrison commented 6 years ago

Hi @PeterGrainfield , I know there is no such option and that's why I think it could be a feature to add. Also, at least for the altcoins I gave as examples, ETH/JPY and BCH/JPY are both available in all the major exchanges (of course the three exchanges supported by r2 are included) in Japan. They are almost as common as the BTC/JPY pair.

The reason why I think it can be added easily without too much work is that the only difference in implementation is to have a different symbol (a string) of the pair name in the request and probably add some local namespace to differentiate the data for each pair.

bitrinjani commented 6 years ago

Hi, currently R2 supports only BTCJPY, but yes, it is possible to enhance it to support altcoins (and other fiat currencies). Not sure when, but I'll add the feature.