Adding collection of information about certificate embedded into mobileprovision

bitrise-io / ipa_analyzer

iOS IPA file analyzer: collects embedded mobileprovisioning and Info.plist information from a .ipa, can generate pretty printed JSON output.

MIT License

80 stars 15 forks source link

Adding collection of information about certificate embedded into mobileprovision #3

Closed guillemm closed 6 years ago

guillemm commented 7 years ago

This pull request is to collect information about the certificate embedded into the mobileprovision file, namely the Common Name and UID.

viktorbenei commented 7 years ago

Thanks for the PR @guillemm !

@godrei pls review and merge ;)

godrei commented 7 years ago

Hi @guillemm ,

sorry for my late response, for first thanks for the PR!

We added tests (rubocop & rspec) to this repo, to allow contributors to safety contribute.

I would ask you to rebase your changes onto current master. You can run the repo test locally by calling bitrise run ci. Please fix the rubocop issues (if any) and write some test, which ensures and documents your changes.

Thanks again!

viktorbenei commented 6 years ago

Closing due to inactivity + merge conflicts.

@guillemm feel free to create a new PR with the updates/changes requested by @godrei and sorry for the inconvenience!