bitrise-steplib / bitrise-step-flutter-build

MIT License
7 stars 14 forks source link

.flutter_settings : support non-string json values #12

Closed benoitskipr closed 3 years ago

benoitskipr commented 5 years ago

hi, the .flutter_settings file can contain values different than strings, like booleans,

  "ios-signing-cert": "iPhone Developer: benoit@***.com (92RAR46KUA)",
  "enable-web": true
}

but the parsing does not take that into account atm, so I get a Failed to unmarshal .flutter_settings file, error: json: cannot unmarshal bool into Go value of type string

https://github.com/bitrise-steplib/bitrise-step-flutter-build/blob/acfbae87b8c6831bf59303eead40a389977b6fae/main.go#L113

sry I don't know Go enough to fix it myself

bitce commented 5 years ago

Hi @benoitskipr!

Thanks for reporting! Could you also send us an URL for a build where this occurs?

alexshikov commented 4 years ago

To reproduce the issue switch to flutter beta channel, enable the web support and run local bitrise run:

flutter channel beta
flutter upgrade
flutter config --enable-web

bitwise run
github-actions[bot] commented 3 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

github-actions[bot] commented 3 years ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.