Code-Signing is disabled for `.app` iOS builds

marius-h commented 6 months ago

Troubleshooting

[x] I've searched discuss.bitrise.io for possible solutions.
Which version of the step is effected? 0.17.0
Is the issue reproducible with the latest version? YES
Does the issue happen sporadically, or every time? EVERY TIME
Is the issue reproducible locally by following our local debug guide? YES

Issue description

When using the flutter build step for building an iOS .app, a --no-codesign parameter is added automatically by the step which disables code-signing. There is no way to disable it at the moment.

See: https://github.com/bitrise-steplib/bitrise-step-flutter-build/blob/d26d1d82661155b26fa3ce5969e8d01669ef7edc/buildspec.go#L208

Bitrise info

Build URL: https://app.bitrise.io/build/b3ea0103-26c4-4a80-aa0c-bcf4a8345695

Steps to reproduce

Add code sign step manage-ios-code-signing

Add flutter build step after code sign

inputs:
    - is_debug_mode: 'true'
    - platform: ios
    - ios_additional_params: "--simulator --debug $BUILD_ATTRIBUTES $BUILD_FLAVOR"
    - project_location: "$BITRISE_FLUTTER_PROJECT_LOCATION"
    - ios_output_pattern: "*build/ios/iphonesimulator/*.app"

bitrise-coresteps-bot commented 3 months ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

Sese-Schneider commented 3 months ago

still important to me

sebjamesmelon commented 3 months ago

I came here to look at if there was a way to achieve this currently, alas.

I was then going to jump in and see if I could fix it but there is a PR there already, though it is failing :)

Any movement possible on https://github.com/bitrise-steplib/bitrise-step-flutter-build/pull/55

bitrise-coresteps-bot commented 3 hours ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

bitrise-steplib / bitrise-step-flutter-build