Skip workflows without external ID [SSW-650]

bitrise-steplib / bitrise-step-pull-intermediate-files

MIT License

0 stars 2 forks source link

Skip workflows without external ID [SSW-650] #8

Closed erosdome closed 1 year ago

erosdome commented 1 year ago

Checklist

[ ] I've read and followed the Contribution Guidelines
[ ] step.yml and README.md is updated with the changes (if needed)

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Changes

Investigation details

Decisions

godrei commented 1 year ago

@zsolt-vicze regarding

if that function is the best place to filter out these. Maybe the caller should do the filtering?

I think yes with the current architecture of the step. BuildIDGetter encapsulates the functionality of listing build ids for later functionalities, so ensuring we list valid build ids is fine here.

Note: a tech improvement would be to do the empty build slug validation here too.