bitrise-steplib / steps-certificate-and-profile-installer

steps-certificate-and-profile-installer
MIT License
13 stars 17 forks source link

Using a vertical bar (|) as a password for a distribution certificate will result in a failure. #59

Closed srea closed 3 years ago

srea commented 3 years ago

If a vertical bar is used as the password for the distribution certificate, the number after the split does not match in the following part, and an error occurs

https://github.com/bitrise-steplib/steps-certificate-and-profile-installer/blob/2bba6a2304ffd0abfdf440d79b1e4fa261a31517/main.go#L356-L357

https://github.com/bitrise-steplib/steps-certificate-and-profile-installer/blob/2bba6a2304ffd0abfdf440d79b1e4fa261a31517/main.go#L359-L361

I think I need to inform Bitrise users that including the vertical bar in the password of the distribution certificate will not work properly.

ex) &Gxa8G|a^tg -> &Gxa8G a^tg

mjones-droid commented 3 years ago

Thank you for reporting this. I've filed a bug report with the developers.

github-actions[bot] commented 3 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

github-actions[bot] commented 3 years ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.