search

bitrise-steplib / steps-codecov

MIT License
3 stars 5 forks source link

Support for Android #2

Closed guitcastro closed 8 years ago

guitcastro commented 8 years ago

This step works for Android as well, but it's no possible to add it to my workflow because of the host_os_tags and project_type_tags. I have created a Android step, but talking with the folks from CodeCov they recommend to use the bash script instead of the python. So I think we can use this steps for both platforms.

viktorbenei commented 8 years ago

Thanks for the feedback! Are you sure that the bash script can work on Linux too? I guess it can, my question is more like: did you try that? ;)

guitcastro commented 8 years ago

@viktorbenei Yep! I am using it in my workflow (as script step)

viktorbenei commented 8 years ago

all right, I'll do the required change and push a new version of the step tomorrow! Thanks for the info & suggestion! ;)

viktorbenei commented 8 years ago

Done & published in v1.0.1 - thanks for the suggestion! 😉

guitcastro commented 8 years ago

@viktorbenei Nice!, now we have to deprecate my step. How can I proceed with that ?

viktorbenei commented 8 years ago

We just introduced this in Bitrise CLI 1.3.x - you have to send a Pull Request into the StepLib, adding a step-info.yml into your step's directory, with a deprecation note and date. Please pick a reasonable removal date, like 3-6 months, unless it's critical to have it removed sooner.

Example step-yml with removal notice: https://github.com/bitrise-io/bitrise-steplib/blob/master/steps/bitrise-artifact-deploy/step-info.yml