bitrise-steplib / steps-deploy-to-bitrise-io

Deploy build artifacts to bitrise.io
MIT License
23 stars 40 forks source link

Display file size warning + continue uploading if an upload fails #167

Closed vshah23 closed 1 year ago

vshah23 commented 1 year ago

Checklist

Version

Requires a MAJOR/MINOR/PATCH version update

Context

We were not trying to upload all artifacts in situations where one artifact in the list failed to create/upload.

This caused situations where raw output logs would not be uploaded yet we still message the user to look for them in the artifacts section of the build.

Changes

Continue uploading artifacts even if one artifact fails to upload.

If an artifact fails to get created we use the error message in the response body in the build log output.

Here's a build showcasing the changes: https://app.bitrise.io/build/de169bb5-f556-4506-af60-63704d4cd22d

Notice the file bigfile failed to upload, yet the file hello_world.txt can still be found in the artifacts tab.

Investigation details

Considered checking for the file size and constructing the warning message at the step side.

Decisions

Decided it's better to keep the message on the system where the check is being made (BE).