search

bitrise-steplib / steps-ftp-upload

Bitrise step to upload a single file or a folder to an FTP server
MIT License
4 stars 12 forks source link

golint error - redundant if ... #18

Closed viktorbenei closed 7 years ago

viktorbenei commented 7 years ago 
+------------------------------------------------------------------------------+
| (2) Go lint                                                                  |
+------------------------------------------------------------------------------+
| id: script                                                                   |
| version: 1.1.4                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: bash                                                                |
| time: 2017-09-20T05:05:52-07:00                                              |
+------------------------------------------------------------------------------+
|                                                                              |
+ read -r line
+ echo '-> Linting: github.com/bitrise-io/steps-ftp-upload'
-> Linting: github.com/bitrise-io/steps-ftp-upload
++ golint github.com/bitrise-io/steps-ftp-upload
+ golint_out='/Users/vagrant/go/src/github.com/bitrise-io/steps-ftp-upload/main.go:231:2: redundant if ...; err != nil check, just return error instead.'
+ [[ /Users/vagrant/go/src/github.com/bitrise-io/steps-ftp-upload/main.go:231:2: redundant if ...; err != nil check, just return error instead. != '' ]]
+ echo '=> Golint issues found:'
=> Golint issues found:
+ echo '/Users/vagrant/go/src/github.com/bitrise-io/steps-ftp-upload/main.go:231:2: redundant if ...; err != nil check, just return error instead.'
/Users/vagrant/go/src/github.com/bitrise-io/steps-ftp-upload/main.go:231:2: redundant if ...; err != nil check, just return error instead.
+ exit 1
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | Go lint (exit code: 1)                                        | 0.91 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-script/issues             |
| Source: https://github.com/bitrise-io/steps-script                           |
+---+---------------------------------------------------------------+----------+