wrong changelog when tags are available

bitrise-steplib / steps-generate-changelog

MIT License

2 stars 7 forks source link

wrong changelog when tags are available #9

Closed cbotsikas closed 3 years ago

cbotsikas commented 4 years ago

Based on the code, when there are more than one tag, the changelog consists of the commits between the last two tags. This is fine, only if the last commit (or the commit the bitrise is invoked) has a tag, otherwise the changelog should contain all commits until the last tag (that's what is written in the description).

In my point of view there are the following schenarios:

No tags: all commits
One tag:
- Tag is on checked out commit: all commits
- Tag is on older commit: commits after the last tag
More than one tag:
- Last tag on checked out commit: commits between the last two commits, including the last one
- Tags on older commits: commits after the last tag

cbotsikas commented 3 years ago

After two months, I can safely assume this issue and the pending PR got lost in the pile of work. Any thoughts about this?

bitce commented 3 years ago

Sorry for the huge delay @cbotsikas! The PR is still in the team's backlog, I'll do what we can to bump to priority, but looking into this is definitely still on our plate.

cbotsikas commented 3 years ago

No problem @bitce, as long as you are aware of this, it's fine for me :). We are already using my forked step in our workflows so it's not a blocker for us.

bitrise-coresteps-bot commented 3 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

bitrise-coresteps-bot commented 3 years ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.