search

bitrise-steplib / steps-google-play-deploy

MIT License
54 stars 38 forks source link

suddenly failing on "validating edit" related to "changesNotSentForReview" #119

Closed thenderson55 closed 3 years ago

thenderson55 commented 3 years ago

My Android build was working fine then suddenly broke on "validating edit" and now fails every attempt to rebuild

version 3.3.0

Build URL: https://app.bitrise.io/build/4ee6640df3f05b3e#?tab=log

Validating edit
Failed to validate edit, error: googleapi: Error 400: Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true. Once committed, the changes in this edit can be sent for review from the Google Play Console UI., badRequest
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | google-play-deploy@3 (exit code: 1)                           | 31.78 sec|
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-google-play-deploy/issues |
| Source: https://github.com/bitrise-io/steps-google-play-deploy               |
+---+---------------------------------------------------------------+----------+
HaswinVidanage commented 3 years ago

Same here,

Is google-deploy step going to support this change? https://developers.google.com/android-publisher/api-ref/rest/v3/edits/commit

lpusok commented 3 years ago

Hello, @thenderson55 @HaswinVidanage Looking into this issue. Do you have any idea why would this happen? Is it due to the the slower review times?

All_apps

Why would uploading to internal track require review? Can you share the current status of the app shown here: All_apps

If this error is received, should we retry with the changesNotSentForReview set to true in all cases?

thenderson55 commented 3 years ago

Ah, yes - there was some rejection in Google Play store - a co-worker changed something in Google Play and it now deploys successfully.

declan-betmate commented 3 years ago

@thenderson55 that's interesting, can you find out what the change in Google Play was at all? We're having the same issue.

HaswinVidanage commented 3 years ago

@thenderson55 could you let us know what the change was?

thenderson55 commented 3 years ago

This was the response I got from the guy who changed something then it could deploy:

The reason the staging version was rejected was "About the Content Ratings policy".
It seems that this was not a problem such as coding, but the problem was that the explanation of the service was reminiscent of "matching/dating service".

According to the staging version, it said "Action required", so it may be built successfully if I modify the explanation. I'll correct it tonight, so please try to build it again tomorrow.

So it was showing a rejection and he received an email then changed the description/explanation and it can build now.

HaswinVidanage commented 3 years ago

Thanks @thenderson55

ok in that case this only happens when there's an existing app rejection from the play store. so a workaround would be for us to first resolve that rejection and submit again.

mateherber commented 3 years ago

We introduced a flag in 3.4.0 where users can decide whether the step should fail when it fails to send the changes to review automatically. The step can handle retrying by providing the changesNotSentForReview. This is the best that is achievable with these new restrictions.

I'll close this issue now, please try the new step version, and should you experience anything out of order, please open another issue.