Add ack_bundle_installation_warning step input - Githubissues

bitrise-steplib / steps-google-play-deploy

MIT License

54 stars 35 forks source link

Add ack_bundle_installation_warning step input #124

Closed Bence1001 closed 3 years ago

Bence1001 commented 3 years ago

Checklist

[x] I've read and accepted the Contribution Guidelines
Requires MINOR version update

Context

https://github.com/bitrise-steplib/steps-google-play-deploy/issues/121
The installation of an App Bundle may be too large and trigger user warning on some Android devices.
When an App Bundle like this is uploaded to Google Play this triggers a warning which needs to be explicitly acknowledged via passing an extra argument to the API/SDK.

Changes

Added new step input: Acknowledge Bundle Installation Warning (ack_bundle_installation_warning).

Default value: false.
Passes ack_bundle_installation_warning argument to the Google Play SDK when uploading an App Bundle.
Added extra error message about this input when this warning is found in the error returned by Google Play SDK.

Investigation details

We were unable to reproduce this warning with our own sample apps. The rules of this warning are not clearly documented, and it seems like it doesn't even trigger in all cases.

Decisions

We allow acknowledging the Bundle installation warning via a dedicated step input rather than hardcoding its value to true.

Bence1001 commented 3 years ago

Waiting for https://github.com/bitrise-steplib/steps-google-play-deploy/pull/122 to be merged before we can merge this.