search

bitrise-steplib / steps-google-play-deploy

MIT License
54 stars 38 forks source link

Status as mandatory parameter #144

Open petr-miklenda opened 2 years ago

petr-miklenda commented 2 years ago

Issue description

In this step, the status is not a mandatory parameter, however upload to GooglePlay is not possible, without specifying it. The documentation mentions the statusUnspecified, however with this value, the upload fails (failed build linked below) with error:

Error 400: Release status must be specified., badRequest

:exclamation: And when status is not filled, upload is successful. However the app is directly released to given track , so I assume, that the completed is used as default value. This is potentially dangerous (and hidden) behavior. Is this please documented anywhere? I wasn't able to found anything related.

Bitrise info

Steps to reproduce

  1. Upload the .apk (or .aab) to GooglePlay using different values of status parameter
    • statusUnspecified - fails (error mentioned above)
    • draft - works OK
    • inProgress - not tested
    • halted - not tested
    • completed - unintentionally tried and seems working OK
    • empty - works, but completed is probably used as default value

Summary

Is it possible to just upload the .apk (or .aab) to GooglePlay, without releasing it? Or releasing at least as a draft is the necessary? If so, can you please make status as mandatory param, to make the upload more clear?

empowerRyan commented 1 year ago

Seconding this, our team found recently that releases were being submitted for immediate Google Play review by this step without the status parameter specified. This prevented us from reviewing release warnings and setting a rollout strategy, as we had been doing without issue before.

We'll be trying out status : draft for our next release train to see how that works.

bitrise-coresteps-bot commented 1 year ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

petr-miklenda commented 1 year ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

The issue still persist.