Closed smuldr closed 2 months ago
Welp, looks like there is a failure in the automated checks but I do not have the right permissions to see what went wrong.
@ofalvai could you could help me getting this PR moving again?
Sorry to tag you like this but I don't really know what the regular process is so I just searched for who did the most recent PR approval.
Hey @smuldr, thank you for the contribution. We'll take a look shortly, I promise!
That is great to hear! Thank you for adding that E2E test too.
Checklist
step.yml
andREADME.md
is updated with the changesVersion
Requires a MINOR version update because it adds new functionality.
Context
This PR adds support for validating edits without committing them, using the validate API. This is useful to check that your config is correct without actually publishing a new release. We would like to run this for our nightly builds so we can make sure that everything still works without resetting our Play Store review status.
Changes
"dry_run"
configuration parameter (default value should befalse
).Investigation details
None (?).
Decisions
I am not very familiar with Go and could not find any tests for the
executeEdit()
logic so I guess we just assume that it works?