bitrise-steplib / steps-google-play-deploy

MIT License
54 stars 38 forks source link

Upload multiple APKs and Bundles #69

Closed JMaroz closed 4 years ago

JMaroz commented 4 years ago

Hi,

i saw that is possibile to upload multiple apks but not a combinations of apk and bundle. Google play allows it, it would be great if bitrise will do the same.

Thanks

Roland-Bak commented 4 years ago

Hey there @JMaroz, that's a great idea! Would you consider creating a feature request about this? 🙂 We collect them on this discuss board, so everyone can vote for their preferred feature and we can see what's mostly in demand 🙂

IAmDarush commented 4 years ago

What's the status of this feature?

JMaroz commented 4 years ago

As far i know there are no progress on this features.

I added a topic on the discuss board https://discuss.bitrise.io/t/upload-multiple-apks-and-bundles/11261

androideveloper commented 4 years ago

Is there a way to upload multiple bundles only?

bitce commented 4 years ago

Hey everyone!

There is no way to do this by using a single step, but you can accomplish this by adding multiple Google Play Deploy steps.

androideveloper commented 4 years ago

@bitce We tried but it didn't work, because only the latest one is being published overriding previous.

Please take a look at this open issue https://discuss.bitrise.io/t/deploy-multiple-aab-android-app-bundles-with-a-single-step/11848

I've tried to modify this part to pass all .aab files further https://github.com/bitrise-steplib/steps-google-play-deploy/blob/eba532cf96510e392446e6027cdb615f456d9a7d/config.go#L136-L142

And now trying out if this works. But anyway it would be a custom bitrise step for us - forked version of the official step. What is the purpose of this check?

bitce commented 4 years ago

hey @androideveloper! We're aware of the feature request, but thanks for bringing it to our attention. What you describe however does not sound expected so please do send us a build URL that exemplifies this so we can check it out.

awenger commented 4 years ago

hey @androideveloper! We're aware of the feature request, but thanks for bringing it to our attention. What you describe however does not sound expected so please do send us a build URL that exemplifies this so we can check it out.

@bitce you proposed the solution with two build steps already to us in January and I send you a email on 30. January with a link to a build that showed that this strategy does not work:

As promised, I gave the two Play Deploy steps a try: https://app.bitrise.io/build/2306be69f3c9c621

The second Step fails with:

Validating edit Failed to validate edit, error: googleapi: Error 403: You cannot rollout this release because it does not allow any existing users to upgrade to the newly added APKs., releaseValidationErrorKeyApkNoUpgradePaths

However I'm not sure if it is caused by it beeing a aab targeting wear devices, or becuase it already created the same release with the same name in the step before

any updated on the possibility to upload two aab with one step?

Providing these information and trying different work arounds costs us hours of work, so please stop stalling us and stop proposing the same thing again and again. This missing "functionality" already cost us days of work. And the investigation and things we tried to work around it caused even more work. I'm happing to do my part and try different things, but seeing now that you just ignored the information we provided 4 month ago, and just ask us to provide the same information again makes me a bit sad.

Sorry for the rant but I'm slowly getting fed up with bitrise.

Let me just quote the bitrise website:

We experienced firsthand the struggle and annoying distractions app developers have to face almost every day. We were those developers. And we will not forget. We are working hard to make developers’ life better.

Please show us that you didn't forget and actually try to make our life better...

bitce commented 4 years ago

Hi @awenger!

First of all, sorry for every miscommunication and confusion I've caused. I can't speak to any product or technical decisions made here, but I fully understand this is frustrating.

Is there any chance we can pick this case up again on your end? I don't seem to be able to locate this conversation that you're referring to (but I do recall.)

In the specific example available from the quote there, we suspect it fails because of the package names being identical, and the second bundle targets no users the previous one did (one being wearOS the other targeting mobile devices).

In case you contact us directly in an e-mail we'd like to ask for more info (as to what the difference is between this packages and what the use case is) offer to try to set up some demo workflow for the scenarios by our Tooling team, as long as you're interested in that.

Let us know!

awenger commented 4 years ago

@bitce thanks for the information, I forwarded the email conversation to you so you can have a look again.

In the specific example available from the quote there, we suspect it fails because of the package names being identical, and the second bundle targets no users the previous one did (one being wearOS the other targeting mobile devices).

This is also what I expect to be the problem for us.

In case you contact us directly in an e-mail we'd like to ask for more info (as to what the difference is between this packages and what the use case is) offer to try to set up some demo workflow for the scenarios by our Tooling team, as long as you're interested in that.

Thanks for the offer, but we prefer to use a single deploy step (as it will result in a single edit on the play store and this is exactly how we would upload our releases manually). So for now we will put our effort into enhancing the play store deploy step, so that we can publish two app bundles with a single step, see: https://github.com/bitrise-steplib/steps-google-play-deploy/pull/80/files

awenger commented 4 years ago

And we just had the first successful deploy of two aab with a single google play deploy step (with the modified version from: https://github.com/bitrise-steplib/steps-google-play-deploy/pull/80 ):

Upload apks or app bundles
Found .aab file: /bitrise/deploy/app-production-release.aab
Found .aab file: /bitrise/deploy/wear-production-release.aab
Uploading /bitrise/deploy/app-production-release.aab 1/2
Uploaded app bundle version: 624
 uploaded mapping file for apk version: 624
Uploading /bitrise/deploy/wear-production-release.aab 2/2
Uploaded app bundle version: 625
 uploaded mapping file for apk version: 625
Done uploading of 2 apps
New version codes to upload: [624 625]
Applications uploaded

However the modification in this PR will most probably not support the original request of this issue, to support multiple apks and aabs. But from what I read about Edits, there should be nothing that would prevent the support of such a functionality.

bitce commented 4 years ago

Thanks for all these details @awenger! I've collected this and forwarded to our Tooling team. They have a lot on their backlog right now, but I'm hoping we can start a discussion sooner than later and update this thread with some good news.

Szabadember commented 4 years ago

This feature was released in version 3.1.1. Now it is possible to upload multiple AAB files as well. Please note that version codes have to be unique for each artifact, for more information see the official docs.