Pull in latest changes from xcode-project

[ubuntudroid]

Over at xcode-project some important fixes regarding target parsing have been done. Would be great if this could be pulled in here as well - our workflows don't build right now which is likely caused by this from looking at the logs.

[bitce]

Hi @ubuntudroid! Can you please include an URL of a build that fails for you, so we can take a look at what are these problems exactly?

[ubuntudroid]

@bitce Sure, here you go: https://app.bitrise.io/build/17bf046e47cb8cc8 (the branch has been renamed in the meantime to feature/appwidget in case you wonder / want to trigger the build manually.

In the end I could fix this particular issue (there is still another unrelated issue with building that branch) by manually adding the following to an otherwise empty target:

CreatedOnToolsVersion = 11.4.1;
ProvisioningStyle = Automatic;

Apparently empty targets are a problem.

So in the end I'm not 100% sure it is caused by the issue fixed in xcode-project, but it might be connected?

[bitce]

I see, that would make sense. Would you be able to turn on Support User access for us? I'd forward this to our engineering team so they can take a look.

[ubuntudroid]

@bitce done ✅

[kylebrowning]

I believe I have a related issue.

Creating AppstoreConnectAPI client
the client created for https://api.appstoreconnect.apple.com/
Analyzing project
configuration: Release
Failed to read project team ID: failed to parse target (1D9B2F1D23898DF7001FB5C8) attributes: key: string("1D9B2F1D23898DF7001FB5C8") not found in: serialized.Object(serialized.Object{"7CB33068200813270043F3A5":map[string]interface {}{"CreatedOnToolsVersion":"9.2", "LastSwiftMigration":"1000"}, "7CB34F1B1D362969004B639D":map[string]interface {}{"CreatedOnToolsVersion":"7.3.1", "LastSwiftMigration":"1020", "SystemCapabilities":map[string]interface {}{"com.apple.ApplicationGroups.iOS":map[string]interface {}{"enabled":"1"}, "com.apple.BackgroundModes":map[string]interface {}{"enabled":"1"}, "com.apple.InAppPurchase":map[string]interface {}{"enabled":"1"}, "com.apple.Keychain":map[string]interface {}{"enabled":"1"}, "com.apple.Push":map[string]interface {}{"enabled":"1"}, "com.apple.SafariKeychain":map[string]interface {}{"enabled":"1"}}}, "7CB6DA0C204841DA001453C5":map[string]interface {}{"CreatedOnToolsVersion":"9.2", "LastSwiftMigration":"1000", "SystemCapabilities":map[string]interface {}{"com.apple.ApplicationGroups.iOS":map[string]interface {}{"enabled":"1"}}}, "7CD7C3F1236B008300059BC8":map[string]interface {}{"CreatedOnToolsVersion":"11.2", "TestTargetID":"7CB34F1B1D362969004B639D"}})
|    

[Robert-Bitrise]

Hi @ubuntudroid and @kylebrowning ! Do you still notice this issue or it has been solved?

[kylebrowning]

I reverted to using the deprecated auto provision step.

[Robert-Bitrise]

@kylebrowning Could you please send a build log with support access which I can use to investigate this issue? Thank you.

[kylebrowning]

Failing Passing before something broke

[Robert-Bitrise]

@kylebrowning Could you please check the following settings?

• Ensure that the Application Identifier exists on the Apple Developer Portal
• Ensures that the project's Capabilities are set correctly in the Application Identifier
• Ensures that the Provisioning Profiles exist on the Apple Developer Portal and are installed for the build
• Ensure that all the available Test Devices exist on the Apple Developer Portal and are included in the Provisioning Profiles

These settings have to be done to be able to use the iOS Auto Provision with AppStore Connect API step.

[kylebrowning]

Yes all of those are correct and, as I put in my last comment there is a build that did pass with App Store connect API and then it broke.

[Robert-Bitrise]

@kylebrowning

What you were using in that successful build was a step with this id: ios-auto-provision The id of the other auto provision step is: ios-auto-provision-appstoreconnect

So this link didn't use the AppStore Connect API based step: https://app.bitrise.io/build/26b87868df02c676#?tab=log

[Robert-Bitrise]

@kylebrowning Did you notice that you have used the same iOS Auto Provision step in those 2 builds what you have sent to me in your previous comment?

[kylebrowning]

I'll double check when I have time. Sorry for the delayed response.

[Robert-Bitrise]

@kylebrowning No problem, thank you for your reply!

[Robert-Bitrise]

Hi @kylebrowning ! Did you have time to double check that what we were talking about earlier? I am looking forward to your reply.

[JakeStoeffler]

I'm having the same issue and it's blocking me from moving off the deprecated iOS Auto Provision with Apple ID path. Here's an example of a failing build: https://app.bitrise.io/build/c33c41a2823a052b

I found a thread about this where others were affected as well: https://discuss.bitrise.io/t/failed-to-apply-code-sign-settings-for-target-failed-to-get-projects-target-attributes/13530

Please let me know what else I can help with so this gets fixed.

[bitce]

Hi @JakeStoeffler, can you please enable Support User access in the Settings of your app, so we can take a look at the project?

[JakeStoeffler]

@bitce Done. You'll notice I was able to work around the issue by adding an empty entry for the target to the TargetAttributes section of project.pbxproj. However, I think that could be avoided if xcode-project was updated in this step.

[bitce]

Thanks for the details @JakeStoeffler. The team seems to agree, we've created a task to do this as soon as we can!

[godrei]

@ubuntudroid and @kylebrowning the xcode-project package update was pulled in version 0.1.2 on 1 Dec 2020. Could you please test the latest version of the step?

[ubuntudroid]

@godrei I'm not actively working on our xcode project at the moment, but I'll check once I'm back on it. Might be a month or two though.

[godrei]

@JakeStoeffler and @kylebrowning could you please try the latest version of the step? There was one more code block requiring TargetAttributes, it is fixed in version 0.1.7

[godrei]

I'll close this issue, but if you need more info/help just open a new issue!