bitrise-steplib / steps-ios-auto-provision

MIT License
20 stars 33 forks source link

TOOL-151 rewrite keychain helper #72

Closed lpusok closed 5 years ago

lpusok commented 5 years ago

Ruby implementation was migrated mostly in a mirror translation fashion. Some responsibilities were left for the future caller, e.g. there is no public ImportCertificates method, only a singular one.

Wrote simple tests for main functions, but it there is room for improvement in terms of tests and testability, e.g. using reader and writer interfaces instead of hardcoded stdins and stdouts.

CI was not updated for the Go implementation.