search

bitrise-steplib / steps-random-quote

Prints a random quote and saves it into $RANDOM_QUOTE
MIT License
0 stars 5 forks source link

Fix crash when parsing HTML encoded quote #12

Closed danbtl closed 6 years ago

danbtl commented 6 years ago

The quotes are HTML encoded, not URL encoded. This causes the crash reported in #7 when encountering a percent character. For example in: http://api.icndb.com/jokes/504

{ "type": "success", "value": { "id": 504, "joke": "Chuck Norris programs occupy 150% of CPU, even when they are not executing.", "categories": ["nerdy"] } }
trapacska commented 6 years ago

Hey @danbtl !

LGTM, thank you for the PR!