search

bitrise-steplib / steps-set-xcode-build-number

Sets the Build Number to the specified value in the Info.plist file for the next build
MIT License
7 stars 11 forks source link

Build number not set to project Extension #14

Closed AnoxySoftware closed 2 years ago

AnoxySoftware commented 5 years ago

We just added this step to our workflow, which works great for the main target of our project, but fails to correctly set the build number in the embedded Extension we have.

This triggers a warning in TestFlight, which states"

CFBundleVersion Mismatch - The CFBundleVersion value '0' of extension 'XXX.app/PlugIns/OneSignalNotificationServiceExtension.appex' does not match the CFBundleVersion value '651' of its containing iOS application 'XXX.app'.

bitce commented 5 years ago

Hi @AnoxySoftware!

Can you send us the related build URL please?

AnoxySoftware commented 5 years ago

Sure @bitce , it happens on all of our builds, but here is one for example: https://app.bitrise.io/build/ea1018e607fd7547

fehersanyi-bitrise commented 5 years ago

Hy there, in this build I can't find this warning 🤔 for me it saysno error uploading

bitce commented 5 years ago

Hi again @AnoxySoftware!

So we've taken a look, and this doesn't seem to be an "issue". By design the step was created to be limited to a single plist file and doesn’t search for any other scenarios.

That said, it's rather strange that nobody reported this limitation before, we've created a task for the team to include this feature in the step :)

AnoxySoftware commented 5 years ago

Thank you @bitce I'll wait for the update.

BirmacherAkos commented 5 years ago

Hi @AnoxySoftware !

Sorry for the delayed answer.

You are right, this step will modify the version number in one Info.plist only. If your IPA contains multiple build targets ( e.g watch app, extensions ), then you would need to add this step to your workflow multiple times for every build target one by one ( with the current target's Info.plist path ).

Currently, we do not plan to change how the step works. I would suggest creating a feature request for modifying the step, to find these Info.plist automatically. https://discuss.bitrise.io/c/feature-request

AnoxySoftware commented 5 years ago

Thx. I just did this and see how it will end up :)

bitrise-coresteps-bot commented 2 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

bitrise-coresteps-bot commented 2 years ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.