search

bitrise-steplib / steps-set-xcode-build-number

Sets the Build Number to the specified value in the Info.plist file for the next build
MIT License
7 stars 11 forks source link

Shouldn't changes made to Info.plist file be commited&pushed to repository? #8

Closed pzmudzinski closed 8 years ago

pzmudzinski commented 8 years ago

I am wondering if changes made to that file shouldn't be commited & pushed to git repository. E.g. bitrise might be used for making TestFlight builds, although AppStore builds (using different scheme/target) might be done locally by developers. In order to set correct build number they have to enter bitrise (or itunes connect) and check which version was used last time.

viktorbenei commented 8 years ago

It is up to you, feel free to commit & push back if you want to - although be careful to not to cause an infinite build cycle by creating new commits which trigger another build..

The feature won't be implemented here, should be a separate step - commit & push in itself can be complex enough and should not be duplicated for every step which changes a file, should be a separate step.

I hope that makes sense, I'll close this issue as it's out of scope for this step, but feel free to ask anything, we're always happy to discuss! :)