search

bitrise-steplib / steps-virtual-device-testing-for-android

MIT License
22 stars 23 forks source link

Correct order values for device info #23

Closed carlonzo closed 6 years ago

carlonzo commented 6 years ago

indexes were inverted and so the values for locale and orientation.

column is printed at line 117. at line 302-303 the same logic is repeated and you can get confirmation that this line was wrong.

BirmacherAkos commented 6 years ago

Hi @carlonzo !

Thanks for the PR. It's a good catch. 👍 The CI is failing but it is not your fault, we have fixed it in another PR (https://github.com/bitrise-steplib/steps-virtual-device-testing-for-android/pull/22).

Because the other PR is already working with the same file, we have added your solution as well. (It would be more complicated if you would need to merge the other PR's fixes and re-open your PR.)

I'm closing this PR. Thanks again for the fix