xcodebuild options for showBuildSettings

yonaskolb commented 1 year ago

Troubleshooting

[x] I've searched discuss.bitrise.io for possible solutions.
Which version of the step is effected? 1.2.3
Is the issue reproducible with the latest version? YES
Does the issue happen sporadically, or every time? EVERY TIME

Issue description

If xcodebuild_options are provided, these options are not passed to invocations of xcodebuild that are used to get build settings with -showBuildSettings. The issue is that if the source packages path or the whole derived data path is customized and the project has swift packages dependencies, then reading from the build settings will re-resolve all the swift packages which can take a long time. The xcodebuild_options should be passed along while getting build settings, as they are when resolving packages, and archiving

Bitrise info

Here you can see that the customized -clonedSourcePackagesDirPath is not passed along to -showBuildSettings and therefore takes 2 and a half minutes

[19:53:53] $ xcodebuild "-project" "/Users/[REDACTED]/git/shop.xcodeproj" "-scheme" "shop-preview" "-resolvePackageDependencies" "-clonedSourcePackagesDirPath" "SourcePackages"
...
[19:54:41] Reading build settings...
[19:54:41] $ xcodebuild "-project" "/Users/[REDACTED]/git/shop.xcodeproj" "-scheme" "shop-preview" "-showBuildSettings"
[19:57:08] Read target settings.

bitrise-coresteps-bot commented 1 year ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

yonaskolb commented 1 year ago

Still an issue

bitrise-coresteps-bot commented 1 year ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

bitrise-coresteps-bot commented 11 months ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.

bitrise-steplib / steps-xcode-archive