search

bitrise-steplib / steps-xcode-build-for-simulator

MIT License
4 stars 18 forks source link

Xcode build log not available on build success #24

Closed jwelton closed 2 years ago

jwelton commented 3 years ago

When the build fails, the log is available using BITRISE_XCODE_RAW_RESULT_TEXT_PATH. However, when the build is successful, the log is not available. This causes a problem when posting warnings & errors to the GitHub PR. It means PR's introducing warnings but that still compile don't have those warnings posted on the PR, reducing their discoverability before merging.

cathyharmon commented 3 years ago

Hello, BITRISE_XCODE_RAW_RESULT_TEXT_PATH does not point to the build log. This points to the raw-xcodebuild-output.log. Currently this is indeed only available when xcodebuild fails and it is not the entire build log. If you would like this file available when xcodebuild succeeds, I can submit a feature request for you. Please let me know.

The build log itself is available for both successful and failing builds. It is available from the UI or can be accessed via the API.

cathy

jwelton commented 3 years ago

Hi @cathyharmon. Sorry I wasn't very clear. I was indeed referring to the Xcode log, not the Bitrise log.

jwelton commented 3 years ago

The Xcode log is what we generate a list of compiler errors and warnings from. Without it on the success case, we're not able to see if anyway warnings were produced during the build. A feature request would be great.

Would you accept PR's? I would be happy to attempt to implement this.

cathyharmon commented 3 years ago

Hello,

That would be awesome! You can find information on contributing at: https://github.com/bitrise-steplib/.github/blob/main/CONTRIBUTING.md

Of course, if this is something that might be more specific to just you, you can fork the step and make changes and use that.

Thanks, Cathy

bitrise-coresteps-bot commented 2 years ago

Hello there, I'm a bot. On behalf of the community I thank you for opening this issue.

To help our human contributors focus on the most relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 90 days, so I marked it as stale.

The community would appreciate if you could check if the issue still persists. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me".

If no comment left within 21 days, this issue will be closed.

bitrise-coresteps-bot commented 2 years ago

I'll close this issue as it doesn't seem to be relevant anymore. We believe an old issue probably has a bunch of context that's no longer relevant, therefore, if the problem still persists, please open a new issue.