bitrise-steplib / steps-xcode-build-for-simulator

MIT License
4 stars 18 forks source link

Convert to Go modules #32

Closed hisaac closed 2 years ago

hisaac commented 2 years ago

Checklist

Version

Requires a MAJOR/MINOR/PATCH version update

I'm not sure if converting to modules is a major, minor, or patch change. Please advise.

Context

While working on https://github.com/bitrise-steplib/steps-xcode-build-for-simulator/pull/31, I ran into an issue with the go-xcode dependencies. I tried updating it using dep, but was unsuccessful, so I thought I'd try my hand at converting the repo to use Go modules instead, and then update it.

Changes

shams-ahmed commented 2 years ago

Also in the Bitrise.yml file please remove dep-update:.

And I don't think we will need Gopkg.toml and Gopkg.lock

hisaac commented 2 years ago

Also in the Bitrise.yml file please remove dep-update:.

And I don't think we will need Gopkg.toml and Gopkg.lock

Should be fixed in https://github.com/bitrise-steplib/steps-xcode-build-for-simulator/pull/32/commits/fce02bbd95fb8cfcfffa0d9c28fc9e9b5bde498f 👍

shams-ahmed commented 2 years ago

@hisaac looking good!

hisaac commented 2 years ago

I should also update the version number. Would you say this would be a minor version bump? Or patch?

shams-ahmed commented 2 years ago

@hisaac let do it on the other PR. merging to master is not classed as a deploy