bitrise-steplib / steps-xcode-build-for-simulator

MIT License
4 stars 18 forks source link

Refactor to ideal step architecture #34

Closed hisaac closed 2 years ago

hisaac commented 2 years ago

Shoutout to @shams-ahmed, @matrangam, and others on the team for the guidance here πŸ™

Checklist

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Updates the step to our "ideal step architecture", with minimal code changes.

Changes

Investigation Details

I used the steps-xcode-build-for-test step as a guide when building out these changes.

Decisions

I decided to keep this first PR focused solely on restructuring the code to our ideal architecture, while making as few real code changes as possible. Most of the code from main.go was copied as-is to step.go, with some exceptions to handle the breakout into the new methods in main.go (ProcessConfig, InstallDependencies, Run, and ExportOutput).

I would still like to spend some time adding some unit tests and doing some other cleanup before releasing this, which I'll work on next.

matrangam commented 2 years ago

Nice, this looks like a great step in the right direction. I'd imagine a bunch of the step code can be cleaned up w/ V2. Then we can start adding some unit tests etc.