bitrise-steplib / steps-xcode-build-for-simulator

MIT License
4 stars 18 forks source link

Prep for Unified CI #36

Closed hisaac closed 2 years ago

hisaac commented 2 years ago

Checklist

Version

Requires a no version update at this time. It will be included in the next release after I add some unit tests.

Context

This migrates this step to our Unified CI, and uplifts the repo to match the checks done for Unified CI.

Changes

hisaac commented 2 years ago

Thank you for the feedback @ofalvai 🙏. I believe I've addressed all of your comments. Let me know if there's anything else.

hisaac commented 2 years ago

Ah, looks like I have to undo some of the changes to the yaml files as well to satisfy our default yamllint config. Will do that ASAP.

ofalvai commented 2 years ago

@hisaac as a newcomer, if you find some of the yamllint rules too strict or meaningless, please raise these issues! We defined our base ruleset once, but we can always iterate on the exact rules to make everyone happy and productive.

hisaac commented 2 years ago

@ofalvai I had to do one more small change to fix the e2e test run, so it dismissed your review.