adding bloom filter with xxhash

bits-and-blooms / bloom

Go package implementing Bloom filters, used by Milvus and Beego.

BSD 2-Clause "Simplified" License

2.44k stars 232 forks source link

adding bloom filter with xxhash #41

Closed nesso99 closed 3 years ago

nesso99 commented 7 years ago

I am a beginner in Golang. Please comment my code. Thank you in advance

lemire commented 3 years ago

Having the option of using xxhash could be interesting. Would you sync your PR with the new main branch and do some performance comparison (before and after).

lemire commented 3 years ago

I will close this.

This is a reasonable change, but before we do so, we need benchmarks to identify the benefits.